Topic: Editing a file messes up filesize?

[cdehmer]

Re. checkbox, I guess what I had pictured is that when the form opens with non-zero entry in the size box (like when you Edit a file), the box should be unchecked. If it opens with blank or zero (like when you Add File), it should be checked. I'm just not sure if that can be done in the code.

Right now, every time I Edit a file, I have to remember to uncheck the box, or I end up blowing away the correct size.

Of course, you've thought a whole lot more about this program than I have in the few hours I've been working with it. 

[GaMerZ]

I will see if I can improve the UI of it because currently in the edit file page, user can choose to upload a new file and hence it will have a new file size if that happens

[Samutz]

This was bugging me so I looked in to it and made my own fix for it.
The problem is that when editing a a file, if "Current File" is selected (rather than Browse File, Upload File, and Remote File), the form processor doesn't check the filesize (does not set $file_size). And this causes it to set the file_size to 0 in the database (unless Auto Detect is unchecked, in that case code later in the script sets $file_size to what was entered in the field.).

Here's my fix:

In /wp-content/plugins/download-manager.php

Find (around line 116):

Code: [Select]

case -1:
$file = $_POST['old_file'];
break;Replace it with:

Code: [Select]

case -1:
$file = $_POST['old_file'];
if (is_remote_file($file)) {
$file = addslashes(trim($file));
$file_size = remote_filesize($file);
if ($file_size=="unknown") {
$file_size = 0;
}
} else {
$file_size = filesize($file_path.$file);
}
break;

[GaMerZ]

nice one there, I think I will add in a hidden field to store the previous file size.

[Samutz]

I did that at first too:

Code: [Select]

$file_size = intval($_POST['old_file_size']);(old_file_size was a hidden field I put in the form).

But the files that had the wrong file_size from the previous problem would keep the wrong file_size rather than being truly auto-detected.

Edit:
Plus, in theory, if someone manually sets the file size, then later decides that they want it auto detected instead, then using the hidden field would just make it keep the old file size (the one that they want replaced with the auto-detected size).

[GaMerZ]

nice point there, I will add this in after my exams.