All Good Things Must Come To An End

As you all know, I have been doing WordPress plugins and supporting it for the past 6 years. These 6 years of my life, I have been through my polytechnic education, my national service as well as my university education.

I just graduated from university in December 2009 and have been looking for full-time jobs. I am offered a full-time job and will be starting work on 1st February 2010.

I regret to say that I am NOT ABLE to provide support for my plugins anymore due to my full-time job commitment. I will leave this forum open and let the community help one another.

However, I WILL still update my plugins whenever I can and you still can report bugs to me via email and I will try to fix it.


Author Topic: Why not count thread-comment?  (Read 2185 times)

0 Members and 1 Guest are viewing this topic.

Offline escapell

  • Newbie
  • *
  • Posts: 6
    • View Profile
Why not count thread-comment?
« on: 14 February 2009, 07:29 »
pls look here:   http://www.teikinka.com/toshiba_comments.html
my all comments is 201, but in last comment page the count displayed 193.
page 1 and 2 is ok,Because there is no thread-comment,
but page 3 not counted thread-comment.page 3 displayed 158(8 thread comments)
page 4  Calculated from 151 not159?

why?

How to make it right?

PS:my discussion  setting : Break comments into pages with 50 comments per page and the  last page displayed by default
wordpress v2.7.1
« Last Edit: 16 February 2009, 05:40 by escapell »

Offline GaMerZ

  • lesterchan.net
  • Administrator
  • *****
  • Posts: 11,536
    • View Profile
  • WordPress Version: WordPress 2.9.x
  • Theme Name: lesterchan.net v3.4
Re: Why not count thread-comment?
« Reply #1 on: 14 February 2009, 14:05 »
It is not tested and not meant for threaded comments. Is it like that with the default comment navigation?

++ lesterchan.net - Lester Chan's Website

I regret to say that I am not able to provide support for my plugins anymore due to my full-time job commitment. I will leave this forum open and let the community help one another.

Offline escapell

  • Newbie
  • *
  • Posts: 6
    • View Profile
Re: Why not count thread-comment?
« Reply #2 on: 15 February 2009, 04:11 »
If I do not use your plugin the count is correct,    pls look here:  http://www.teikinka.com/2009calendar.html   

but use your plugin   and   have thread-comment the count is incorrect。

Offline GaMerZ

  • lesterchan.net
  • Administrator
  • *****
  • Posts: 11,536
    • View Profile
  • WordPress Version: WordPress 2.9.x
  • Theme Name: lesterchan.net v3.4
Re: Why not count thread-comment?
« Reply #3 on: 15 February 2009, 13:48 »
I am referring to the default comment navi.
Code: [Select]
<div class="navigation">
<div class="alignleft"><?php previous_comments_link() ?></div>
<div class="alignright"><?php next_comments_link() ?></div>
</div>
Does it display correctly?

I tested and WP does not count threaded comment as 1 for the purpose of paging.

++ lesterchan.net - Lester Chan's Website

I regret to say that I am not able to provide support for my plugins anymore due to my full-time job commitment. I will leave this forum open and let the community help one another.

Offline escapell

  • Newbie
  • *
  • Posts: 6
    • View Profile
Re: Why not count thread-comment?
« Reply #4 on: 16 February 2009, 01:19 »
YES  you said right。WP does not count threaded comment。
use default comment navi  also have that problem。

Could you make it right in your plugin?

Offline GaMerZ

  • lesterchan.net
  • Administrator
  • *****
  • Posts: 11,536
    • View Profile
  • WordPress Version: WordPress 2.9.x
  • Theme Name: lesterchan.net v3.4
Re: Why not count thread-comment?
« Reply #5 on: 16 February 2009, 03:20 »
Nope, I still relies on WP to get me info on what the plugin need. So if WP tells me there is 3 comments in this page, means this is only 3.

++ lesterchan.net - Lester Chan's Website

I regret to say that I am not able to provide support for my plugins anymore due to my full-time job commitment. I will leave this forum open and let the community help one another.