Topic: WP-Download Manager add and edit don't work in WP MU after upgrading to 2.8.5.2

[intercer]

Hi,

Wonder if someone else has this issue. The WP-Download Manager worked fine until this monday when I upgraded WP MU to 2.8.5.2.

When I try to add or edit an existing item in the download list, it redirects to the main blog admin page in my wp-mu.

The public download page works fine:
http://intercer.net/blogs/egwhiteaudio/descarca/

My configuration:
   1. WordPress Version 2.8.5.2 (WP MU, directories)
   2. Theme Name - Custom theme
   3. Blog URL http://intercer.net/blogs/egwhiteaudio/descarca/  (download page)
   4. Problem Plugin Name And Version WP-Download Manager 1.50
   5. PHP And MYSQL Version  PHP5, Mysql 5
   6. Possible Conflicting Plugins (Optional)

I had also the issue where all items went "hidden", but I changed the file_permission to -1 and made them public again.

To solve the add/edit issue for the moment, I had to go directly to the database.

Thanks,

Lucian

[GaMerZ]

I know about this and I thought I fixed it. I am still figuring it out why this problem happens because I can't seem to reproduce it on my localhost

[intercer]

I downgraded to WP MU 2.8.4 and now it is working fine. So, probably was not related to your script.

In 2.8.5.2 I also had some issues with other plugins that redirected to main blog instead of showing the results.

I will wait for a future version of WP MU, hopefully will work at that time.

Thanks,

Lucian

[intercer]

I did another try today and upgraded the WP-MU to 2.8.6, but I get the same issue where I can't add or edit items in WP-Download manager. I downgraded again to 2.8.4 to make it work.

I wonder if someone else has the same issue or it is something specific to my blog.

Thanks,

Lucian

[GaMerZ]

Hmmm from 2.8.4 to 2.8.6 not much changes to the core, there are just bug fixes. It should not affect anything.

[intercer]

What I noticed is that also some other script is affected in a similar way. It is like these scripts (including the WP-Download Manager scripts for add/edit) are posting to the blog index.php, instead of posting to their own scripts. Or maybe it is a redirection somewhere...

I thought it is related to my main theme, but that remains unchanged after upgrade. (I use the bp-home, bp-sn-parent from Buddypress), so I don't think it's this.

My guess is that this is related to somewhere in a WPMU function that has to deal with redirection. I have to dig more into it.

Again, I don't think this is related to your plugin, it just happend to be one of the affected scripts after upgrade.

Thanks,

Lucian

[GaMerZ]

Thanks =) let me know if you need me to change anything on my side.

[intercer]

Hi,

We found a solution for this issue.

We had to replace $_SERVER['PHP_SELF'] occurences

with

$_SERVER['REQUEST_URI']

in wp-download manager files.

$_SERVER['REQUEST_URI'] contains the query string.

We did 5 replacements in your latest version 1.50 files.

Here is what I have now:
download-add line 106
<form method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>" enctype="multipart/form-data">

download-manager line 280
<form method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>" enctype="multipart/form-data">

download-options line 111
<form method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>">

download-templates line 149
<form method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>">

download-uninstall line 96
<form method="post" action="<?php echo $_SERVER['REQUEST_URI']; ?>">

Here is a help link where we got the idea:
http://wordpress.org/support/topic/218577

If you consider, you can test these and make these changes to your plugin in a later version.

Thanks,

Lucian

[GaMerZ]

Oh this form issue, actually the correct code is:

Code: [Select]

<form method="post" action="<?php echo admin_url('admin.php?page='.plugin_basename(__FILE__)); ?>">I will be using this for all my plugin.

[intercer]

$_SERVER['REQUEST_URI'] gets all the submitted variables in it, that's why I removed the other variables in the form, as I get them with $_SERVER['REQUEST_URI'].

Wish you happy holidays!

Thanks,

Lucian

[GaMerZ]

Thanks Lucian =) Try my code, it it technically the correct way to do it.